-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Search): custom category layout renderer #3672
feat(Search): custom category layout renderer #3672
Conversation
💖 Thanks for opening this pull request! 💖 Here is a list of things that will help get it across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Codecov Report
@@ Coverage Diff @@
## master #3672 +/- ##
==========================================
- Coverage 99.84% 99.82% -0.03%
==========================================
Files 177 180 +3
Lines 3145 2792 -353
==========================================
- Hits 3140 2787 -353
Misses 5 5
Continue to review full report at Codecov.
|
Hey @layershifter! We would love to hear your feedback on this PR. This is a customization we have been looking for for a while! Thank you, Patrick |
@@ -21,7 +21,7 @@ const SearchTypesExamples = () => ( | |||
examplePath='modules/Search/Types/SearchExampleCategory' | |||
/> | |||
<ComponentExample | |||
title='Category (Custom Render)' | |||
title='Category (Custom Render) v2' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not version the example titles in this way. It will be confusing with the semver already in place.
This is really fantastic, thanks for the great work. I'll get this merged and shipped. |
POC for: #3630