Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(AutoControlledComponent): align API of trySetState() with React's #3731

Merged
merged 2 commits into from
Aug 4, 2019

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Aug 4, 2019

This PR is a slice of changes for AutoControlledComponent from #3452. The same changes were applied for Stardust UI, too.


This PR updates the trySetState() method of AutoControlledComponent to have the same API as setState() in React class components.

@codecov-io
Copy link

Codecov Report

Merging #3731 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3731   +/-   ##
=======================================
  Coverage   99.83%   99.83%           
=======================================
  Files         175      175           
  Lines        3120     3120           
=======================================
  Hits         3115     3115           
  Misses          5        5
Impacted Files Coverage Δ
src/modules/Search/Search.js 99.54% <100%> (ø) ⬆️
src/modules/Rating/Rating.js 100% <100%> (ø) ⬆️
src/modules/Dropdown/Dropdown.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c71341...71b26ba. Read the comment docs.

@layershifter layershifter merged commit 0d66fa7 into master Aug 4, 2019
@delete-merged-branch delete-merged-branch bot deleted the chore/acc-try-set-state branch August 4, 2019 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants