Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced image urls #3902

Closed
wants to merge 1 commit into from
Closed

Replaced image urls #3902

wants to merge 1 commit into from

Conversation

akhilaravind
Copy link

Images was not rendering in the sandbox fiddles, so replaced image URL so that it will render the image in sandbox fiddles. Additional url was added to image src that was preventing the image render.

Replaced image URL so that it will render the image in sandbox fiddles.
@welcome
Copy link

welcome bot commented Feb 27, 2020

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-io
Copy link

Codecov Report

Merging #3902 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3902   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files         178      178           
  Lines        3150     3150           
=======================================
  Hits         3145     3145           
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dbab6b...80d049b. Read the comment docs.

@layershifter
Copy link
Member

@akhilaravind thanks for contributing!

However, as you may mention in this case it will not be enough to fix a single example. So I did a fix #3758 for all examples some time ago.

Please let us know if the issue still exists. I verified it on this example and it works like a charm.

@akhilaravind akhilaravind deleted the patch-1 branch September 1, 2020 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants