Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dropdown): compute proper selectedIndex in multiple #4006

Merged
merged 1 commit into from
Jul 29, 2020

Conversation

layershifter
Copy link
Member

Fixes #4005.


Introduces the same behavior as in vanilla SUI.

Before

dropdown-multiple-before

After

dropdown-multiple-after

@github-actions
Copy link

size-limit report

Path Size
bundle-size/dist/Button.size.js 70.84 KB (0%)
bundle-size/dist/Icon.size.js 33.41 KB (0%)
bundle-size/dist/Image.size.js 66.13 KB (0%)
bundle-size/dist/Portal.size.js 49.9 KB (0%)

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2020

Codecov Report

Merging #4006 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4006   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files         184      184           
  Lines        3233     3234    +1     
=======================================
+ Hits         3228     3229    +1     
  Misses          5        5           
Impacted Files Coverage Δ
src/modules/Dropdown/utils/getSelectedIndex.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28eee26...fd70f10. Read the comment docs.

@layershifter layershifter merged commit 50ec408 into master Jul 29, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix/dropdown-multiple-index branch July 29, 2020 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown: multiple selection does not handle selectedIndex properly
2 participants