Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'template arguments' parameter #436

Merged
merged 1 commit into from
Oct 11, 2018
Merged

Remove 'template arguments' parameter #436

merged 1 commit into from
Oct 11, 2018

Conversation

s7eph4n
Copy link
Contributor

@s7eph4n s7eph4n commented Oct 1, 2018

This PR is made in reference to: #

The 'template arguments' parameter was introduced for compatibility and can be removed in SRF 3.0

This PR includes:

  • Update of RELEASE-NOTES.md
  • Tests (unit/integration)
  • CI build passed

It was introduced for compatibility and can be removed in SRF 3.0
Copy link
Member

@JeroenDeDauw JeroenDeDauw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kghbln
Copy link
Member

kghbln commented Oct 10, 2018

@s7eph4n Can this be merged for SRF 3.0.0?

@s7eph4n
Copy link
Contributor Author

s7eph4n commented Oct 11, 2018

It should be merged, actually. It removes a parameter.

@kghbln kghbln merged commit 158651e into master Oct 11, 2018
@kghbln kghbln deleted the tree-format branch October 11, 2018 18:47
@kghbln
Copy link
Member

kghbln commented Oct 11, 2018

It should be merged, actually. It removes a parameter.

Ok, done. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants