Move Cloudflare Workers instructions #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SerpentBytes
added
✨ enhancement
SerpentBytes
requested review from
humphd,
CDPhu,
SerpentBytes,
batunpc and
saminarp
CONTRIBUTING.md
Outdated
|
|
||
| 1. Run `npx wrangler dev src/index.js` in your terminal to start a development server |
There was a problem hiding this comment.
You could make it more generic: npx wrangler dev <filepath> in case we decide to add more workers later.
SerpentBytes
requested changes
Nov 18, 2022
SerpentBytes
requested changes
Nov 18, 2022
rudychung
requested review from
SerpentBytes
and removed request for
humphd,
CDPhu,
batunpc and
saminarp
SerpentBytes
approved these changes
Nov 18, 2022
|
Whoops, didn't mean to remove the other requested reviewers. Could you add them back |
Done. |
CDPhu
approved these changes
Nov 18, 2022
batunpc
approved these changes
Nov 18, 2022
There was a problem hiding this comment.
Thank you @rudychung ! please squash the commits before merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #12
Re-located the Cloudflare Workers instructions from the top of
worker/index.jstoCONTRIBUTING.md.