-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added linting #22
Added linting #22
Conversation
… from export to add proptype validation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please format your code using a formatting tool like prettier
?
I would appreciate it if you could file an issue about the missing prettier
configuration, as well.
@sfrunza13 Also, could you update the |
added prettier and to Contributing md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some problems:
- We currently have two PRs. One for adding a linter (Added linting #22) and another for adding a formatter (Configure prettier for this project. #24)
- Prettier configuration for the codebase is outside the scope of this PR, as it is related to ( Configure prettier for this project. #24). Merging (Added linting #22) and (Configure prettier for this project. #24) will add
prettier
twice to the project. I requested you to only format your code. - Finally, there's a merge conflict that needs to be resolved. It seems like you are formatting
package*.json
files, somehow, even though you are ignoring them in.prettierignore
. Maybe the IDE is doing it?
continued in 25 |
Added linting
Separated export from function components and added Prop Type Validation
Added github actions workflow for linting
closes #21