Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added linting #22

Closed
wants to merge 2 commits into from
Closed

Added linting #22

wants to merge 2 commits into from

Conversation

sfrunza13
Copy link

@sfrunza13 sfrunza13 commented Nov 20, 2022

Added linting
Separated export from function components and added Prop Type Validation
Added github actions workflow for linting

closes #21

@sfrunza13 sfrunza13 marked this pull request as ready for review November 20, 2022 02:38
@SerpentBytes SerpentBytes added the ✨ enhancement New feature or request label Nov 20, 2022
@SerpentBytes SerpentBytes requested review from humphd and CDPhu November 20, 2022 03:07
Copy link
Collaborator

@SerpentBytes SerpentBytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please format your code using a formatting tool like prettier?

I would appreciate it if you could file an issue about the missing prettier configuration, as well.

@SerpentBytes
Copy link
Collaborator

@sfrunza13 Also, could you update the CONTRIBUTING.md file with information on how to check for lint errors?

@sfrunza13
Copy link
Author

@sfrunza13 Also, could you update the CONTRIBUTING.md file with information on how to check for lint errors?

added prettier and to Contributing md

Copy link
Collaborator

@SerpentBytes SerpentBytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some problems:

@sfrunza13
Copy link
Author

continued in 25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add linting and preliminary workflow for CI
2 participants