Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project creation form UI #28

Merged
merged 6 commits into from
Dec 5, 2022
Merged

Add project creation form UI #28

merged 6 commits into from
Dec 5, 2022

Conversation

rudychung
Copy link
Contributor

@rudychung rudychung commented Dec 1, 2022

Description

Closes #6

Behaviour

Screenshot

@humphd
Copy link
Collaborator

humphd commented Dec 1, 2022

@rudychung can you put up some screenshots or host it so people can try?

@rudychung
Copy link
Contributor Author

Sure, there's no functionality currently, so I've attached a screenshot.

src/App.js Outdated Show resolved Hide resolved
src/ProjectForm.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@SerpentBytes SerpentBytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for creating this PR and putting in all the hard work!
I have requested some changes.
Let me know your thoughts!

src/ProjectForm.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@SerpentBytes SerpentBytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some additional feedback.

@rudychung rudychung marked this pull request as ready for review December 3, 2022 17:56
Copy link
Collaborator

@CDPhu CDPhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@SerpentBytes SerpentBytes requested review from humphd and CDPhu and removed request for CDPhu December 4, 2022 03:54
@SerpentBytes SerpentBytes added the ✨ enhancement New feature or request label Dec 4, 2022
@SerpentBytes SerpentBytes merged commit 2789a90 into Seneca-CDOT:main Dec 5, 2022
@rudychung rudychung deleted the issue-06 branch December 6, 2022 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create the app's UI
4 participants