Fixed link to docs #3670
Fixed link to docs #3670
Conversation
|
|
manekenpix
added
hacktoberfest-accepted
area: docusaurus
| @@ -120,7 +120,7 @@ const config = async () => { | |||
| items: [ | |||
| { | |||
| label: 'Documentation', | |||
| href: 'https://docusaurus.io/docs/', | |||
| href: 'https://telescope.cdot.systems/docs/overview/', | |||
There was a problem hiding this comment.
Thank you for your contribution. Always good to have new contributor.
We have 2 environments for this
One staging: https://dev.telescope.cdot.systems/docs/overview/
One production: https://telescope.cdot.systems/docs/overview/
I don't think it's a good idea to redirect always to production.
I believe you can do relatives path see
There was a problem hiding this comment.
Hi @Kevan-Y ,
Thank you for your feedback, I changed the link, hopefully it's okay :)
There was a problem hiding this comment.
@mnosov622 it looks like you've switched to using an absolute URL to staging now, which also won't work. What @Kevan-Y is saying is that we need this to work no matter where we host this site. The link needs to take into account the fact that we host this same site on different URLs.
There was a problem hiding this comment.
Hi @humphd ,
Oh, yes, I'm sorry, i get it. Please let me know if everything is fine now :)
There was a problem hiding this comment.
Thanks a lot for doing this. Please squash and rebase your commits then we can have it merged into the master branch :)
https://telescope.cdot.systems/docs/contributing/git-workflow
|
Hello! I'm sorry, I will make another pull request, hopefully it's okay :) |
|
I created another pull request, thank you :) #3674 |
GitHub now has squash and merge button (I use too much of this button😅), but we just need to make sure the branch has the latest stuff |
|
Thank you, Kevan ! I didn't know about that :) |
Hello!
Please review the bug fix.
Issue This PR Addresses
USAGE: Fixes Documentation link points to Docusaurus #3445
Type of Change
Bug
Description
Fixed the link to the Telescope documentation, the previous link was going to docusaurus documentaton
Steps to test the PR
Checklist
Quality: This PR builds and passes our npm test and works locally
Tests: This PR includes thorough tests or an explanation of why it does not
Screenshots:
Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)