Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #3615(Reopen) #3771

Merged
merged 1 commit into from
Nov 21, 2022
Merged

Fixed issue #3615(Reopen) #3771

merged 1 commit into from
Nov 21, 2022

Conversation

liutng
Copy link
Contributor

@liutng liutng commented Nov 21, 2022

Issue This PR Addresses

This is a reopened PR to close #3615

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

In this PR, an extra query param expand is added to the URL /posts in posts services.When expand=1, there will be extra data of author, title, and publishDate returned.When expand does not equal 1, or expand does not present in the request, the request will return the data like before.

Steps to test the PR

Load the posts page in the react-native app, and observe if the extra fields of data are returned by /posts. This requires the react-native app to add "expand=1" to its request query params of /posts as well.

Here's what does the request and data look like.
https://user-images.githubusercontent.com/8223139/202312171-0f3c2eca-fe9c-4eac-b8a6-70d36bad6bd0.png

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@gitpod-io
Copy link

gitpod-io bot commented Nov 21, 2022

@liutng
Copy link
Contributor Author

liutng commented Nov 21, 2022

@humphd Hi, I've made a new PR to fix my previous broken PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants