-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use responsive images where appropriate #63
Comments
We're seeing a lot of people trying to do image centering with various CSS techniques. Instead of inventing our own, let's rely on what we get for free from IdealImage. NOTE: it is actually based on https://github.com/endiliey/react-ideal-image, which does a lot for us. |
|
Hi @humphd, I am new to this project and this issue is interesting. Which specific files should I apply this features? |
@nguyenhung15913 it's a good question. There's a few things we need:
|
@humphd Hi David, I applied and use Plugin-ideal-image but there was not any prop to center image. Should I keep the original method inside the |
@humphd Also the props which are
However
|
In #46 we're adding the Docusaurus ideal-image plugin. It lets you use an
<Image />
component in your Markdown, and then automatically generates ideal image sizes, based on props you include:We should look at where to use this in our docs. Ideal candidate images would be those that are large enough, and can be given multiple sizes for different viewports. This would help a lot on mobile.
The text was updated successfully, but these errors were encountered: