-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audit input-functions.md #59
Conversation
* Add alt text to images * Encase key words in backticks * Add missing '-' * Remove extra indentation from code blocks * Add missing comma * Remove empty bullet point * Add title to frontmatter * Improve image centering * Add descriptive text to link * Add div.mdImg class for image centering Alter CSS for markdown images * Combine .mdImg with div.mdImg * Use div instead of span in functions.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In #46 we're adding the ideal-image
plugin, which will do this image optimization and centering for us, cc @aserputov: can you confirm that I'm correct about this?
I think that we should probably switch to using this everywhere vs. doing our own styling.
@a-rokay, that's great work you did here, but as @humphd mentioned above, it's probably better to use the Docusaurus internal plugin |
Should I wait for #46 to be merged before continuing? |
No, we can do it in #63, just leave a comment there. |
I'm not sure what you want me to comment, just that |
Yes, I don't want to lose track of knowledge, so we need to move unfinished work items forward into new or existing issues before we close things. |
Got it, should I remove the image centering and CSS from this PR? |
@a-rokay you can include it, but later we need to update all our uses of it. |
Great Job many thanks! |
This PR is an audit of
input-functions.md
:For the image centering, I went with the
text-align: center
approach which requires the image to be in adiv
tag. So I combined the existing.mdImg
class with adiv.mdImg
class that does the centering. Because of this, I had to change thespan
tags infunctions.md
todiv
tags. Everything works as expected.Let me know if I missed anything.
Fixes #33