Audit and Fix pointers-arrays-and-structs.md #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add alt text for image * add admonitions in place of blockquotes * use inline code where needed * add frontmatter with correct info
|
Nice work, @Antonio-Bennett! nit:
can be wrapped with backticks for clarity and consistency with the one on line 189. |
humphd
requested changes
Nov 19, 2021
Reza9472
reviewed
Nov 20, 2021
| @@ -164,9 +171,9 @@ The above program produces the following output: | |||
| 5611 | |||
| ``` | |||
|
|
|||
| Caution | |||
|
|
|||
| :::caution | |||
| The syntactic equivalence between pointer parameters and array names does not extend to the definition of an array. We cannot replace the definition of an array with a pointer definition. An array definition allocates the stated number of memory locations for all of the elements in the array. A pointer definition **allocates only one memory location to hold a single address**. | |||
There was a problem hiding this comment.
There are a couple of places in all of the file where after a sentence, you can see a an extra space.
Please check the image below:
It's should be an easy fix
There was a problem hiding this comment.
One thought for this! I think it happened because a writer who first wrote it put the sentences in a different row, and in markdown, it considers as another single space unless you put another line. It considers different lines without an extra next line in one single paragraph. And it seems okay in the MD since markdown automatically collapses the unnecessary whitespaces.
humphd
approved these changes
Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89