Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Weekly Schedule to footer #55

Merged
merged 1 commit into from
Nov 11, 2021

Conversation

kiennguyenchi
Copy link
Contributor

Solve Issue #54

I added hyperlink of Weekly Schedule to the footer in docusaurus.config.js.
footer

I removed hyperlink of Weekly Schedule in Contents page in docs/intro.md.
content

@aserputov
Copy link
Contributor

aserputov commented Nov 8, 2021

Why it looks like "prettier" didn't work? I think it should be something like this >

          label: "Contents",
          to: "/",
        },
        {
          label: "Weekly Schedule",
          to: "/weeklyContents",
        },

@kiennguyenchi
Copy link
Contributor Author

Why it looks like "prettier" didn't work? I think it should be something like this >

          label: "Contents",
          to: "/",
        },
        {
          label: "Weekly Schedule",
          to: "/weeklyContents",
        },

So you mean that I should replace the single quotes with double quotes? We use single quotes in the entire file, so I think we should not.

@humphd
Copy link
Contributor

humphd commented Nov 8, 2021

We don't have prettier in the tree yet, see #50.

@aserputov
Copy link
Contributor

aserputov commented Nov 8, 2021

@kiennguyenchi @humphd what I meant exactly is this ->
Screen Shot 2021-11-08 at 6 43 43 PM
I didn't see anything bad in this PL, except this.
Overall, it looks good to me...

@ycechungAI
Copy link

I have also tested this and nothing to change from above comments

@CameronGray1210 CameronGray1210 merged commit 4f58857 into Seneca-ICTOER:main Nov 11, 2021
@CameronGray1210
Copy link
Collaborator

Thanks - this makes sense and I'm sure will be used by many as another quick way to return to the weekly schedule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants