fix findings

apps/sensenet/src/components/settings/stats-storage-widget.tsx

@@ -1,4 +1,4 @@
-import { returnValueWithUnit } from '@sensenet/controls-react'
+import { formatSize } from '@sensenet/controls-react'
 import { createStyles, makeStyles, Paper, useTheme } from '@material-ui/core'
 import React from 'react'
 import { useWidgetStyles } from '../../globalStyles'
@@ -42,7 +42,7 @@ export const StorageWidget: React.FunctionComponent<StorageWidgetProps> = (props
           <span>{localization.storage}</span>
           <span>
             {localization.used(
-              returnValueWithUnit(allUsage),
+              formatSize(allUsage),
               `${numberFormatter.format(round(props.data.subscription.plan.limitations.storage / 1024))} GB`,
             )}
           </span>

packages/sn-controls-react/src/fieldcontrols/file-size.tsx

@@ -8,26 +8,10 @@ import InputAdornment from '@material-ui/core/InputAdornment'
 import TextField from '@material-ui/core/TextField'
 import Typography from '@material-ui/core/Typography'
 import React, { useState } from 'react'
-import { changeTemplatedValue } from '../helpers'
+import { changeTemplatedValue, formatSize } from '../helpers'
 import { ReactClientFieldSetting } from './client-field-setting'
 import { defaultLocalization } from './localization'
 
-const units = ['byte', 'KB', 'MB', 'GB', 'TB']
-
-export const round = (num: number, precision = 1) => {
-  const multiplier = Math.pow(10, precision)
-  return Math.round((num + Number.EPSILON) * multiplier) / multiplier
-}
-
-export const returnValueWithUnit = (fieldValueNumber: number, index = 0): string => {
-  const inHigherUnit = round(fieldValueNumber / 1024)
-  if (inHigherUnit >= 1 && units.length > index + 1) {
-    return returnValueWithUnit(inHigherUnit, index + 1)
-  } else {
-    return `${fieldValueNumber} ${units[index]}`
-  }
-}
-
 /**
  * Field control that represents a Number field. Available values will be populated from the FieldSettings.
  */
@@ -99,7 +83,7 @@ export const FileSizeField: React.FC<ReactClientFieldSetting<NumberFieldSetting>
           </Typography>
           <Typography variant="body1" gutterBottom={true}>
             {props.fieldValue && props.fieldValue !== '0' ? (
-              <>{returnValueWithUnit(toNumber(props.fieldValue)!, 0)}</>
+              <>{formatSize(toNumber(props.fieldValue)!, 0)}</>
             ) : (
               localization.noValue
             )}

packages/sn-controls-react/src/helpers.ts

@@ -21,3 +21,19 @@ export const isFullWidthField = (field: { fieldSettings: FieldSetting }, content
     field.fieldSettings.Type === 'LongTextFieldSetting'
   )
 }
+
+const units = ['byte', 'KB', 'MB', 'GB', 'TB']
+
+export const round = (num: number, precision = 1) => {
+  const multiplier = Math.pow(10, precision)
+  return Math.round((num + Number.EPSILON) * multiplier) / multiplier
+}
+
+export const formatSize = (fieldValueNumber: number, index = 0): string => {
+  const inHigherUnit = round(fieldValueNumber / 1024)
+  if (inHigherUnit >= 1 && units.length > index + 1) {
+    return formatSize(inHigherUnit, index + 1)
+  } else {
+    return `${fieldValueNumber} ${units[index]}`
+  }
+}