Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix execute action dialog's monaco editor cache #1007

Merged
merged 2 commits into from
Oct 9, 2020

Conversation

taki9
Copy link
Contributor

@taki9 taki9 commented Oct 8, 2020

No description provided.

@taki9 taki9 requested review from herflis and enikonemeth October 8, 2020 13:43
@taki9 taki9 self-assigned this Oct 8, 2020
@sensenet
Copy link

sensenet bot commented Oct 8, 2020

Site name Url Last deploy
sn-react-component-docs-dev https://5f8055db28519294cba4f73a--sn-react-component-docs-dev.netlify.app Fri Oct 09 2020 - 12:22:09 GMT+0000 (Coordinated Universal Time)
sn-app-dev https://5f8055e2befcd789a581a876--sn-app-dev.netlify.app Fri Oct 09 2020 - 12:21:55 GMT+0000 (Coordinated Universal Time)

@codecov
Copy link

codecov bot commented Oct 8, 2020

Codecov Report

Merging #1007 into develop will decrease coverage by 0.02%.
The diff coverage is 95.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1007      +/-   ##
===========================================
- Coverage    92.27%   92.25%   -0.03%     
===========================================
  Files          217      217              
  Lines         5915     5923       +8     
  Branches      1514     1519       +5     
===========================================
+ Hits          5458     5464       +6     
- Misses         457      459       +2     
Impacted Files Coverage Δ
packages/sn-client-utils/src/disposable.ts 100.00% <ø> (ø)
...r-react/src/components/page-widgets/RotatePage.tsx 100.00% <ø> (ø)
packages/sn-controls-react/src/helpers.ts 81.81% <66.66%> (-18.19%) ⬇️
packages/sn-client-utils/src/path-helper.ts 100.00% <100.00%> (ø)
...-controls-react/src/fieldcontrols/AutoComplete.tsx 100.00% <100.00%> (ø)
...controls-react/src/fieldcontrols/Avatar/Avatar.tsx 92.18% <100.00%> (ø)
...es/sn-controls-react/src/fieldcontrols/Boolean.tsx 95.83% <100.00%> (ø)
...n-controls-react/src/fieldcontrols/ColorPicker.tsx 100.00% <100.00%> (ø)
...sn-controls-react/src/fieldcontrols/DatePicker.tsx 96.55% <100.00%> (+0.25%) ⬆️
...-controls-react/src/fieldcontrols/DropDownList.tsx 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5405c5b...e74f936. Read the comment docs.

@taki9 taki9 merged commit b305f01 into develop Oct 9, 2020
@taki9 taki9 deleted the fix/execute-action-cache branch October 9, 2020 12:26
@taki9 taki9 linked an issue Oct 9, 2020 that may be closed by this pull request
shinnlok pushed a commit to shinnlok/sn-client that referenced this pull request Oct 13, 2020
aslafy-z pushed a commit to aslafy-z/sn-client that referenced this pull request Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Execute action dialog model cache
3 participants