Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redux Store typings cleanup #101

Merged
merged 12 commits into from
Feb 8, 2019
Merged

Redux Store typings cleanup #101

merged 12 commits into from
Feb 8, 2019

Conversation

gallayl
Copy link
Contributor

@gallayl gallayl commented Feb 1, 2019 •
edited
Loading

  • updated redux-di-middleware to 3.0.0
  • simplified type definitions

@gallayl gallayl self-assigned this Feb 1, 2019
@gallayl gallayl changed the title [KFI]chore(packages): updated redux-di-middleware to 3.0.0 Redux Store typings cleanup Feb 1, 2019
@codecov
Copy link

codecov bot commented Feb 1, 2019 •
edited
Loading

Codecov Report

Merging #101 into develop will increase coverage by 0.01%.
The diff coverage is 63.63%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #101      +/-   ##
===========================================
+ Coverage    87.12%   87.13%   +0.01%     
===========================================
  Files          104      104              
  Lines         3130     3125       -5     
  Branches       736      735       -1     
===========================================
- Hits          2727     2723       -4     
+ Misses         403      402       -1
Impacted Files Coverage Δ
...ent-viewer-react/src/components/DocumentViewer.tsx 86.84% <ø> (ø) ⬆️
...s/sn-document-viewer-react/src/components/Page.tsx 73.33% <ø> (ø) ⬆️
.../src/ContentList/CellTemplates/DisplayNameCell.tsx 100% <100%> (ø) ⬆️
...search-react/src/Components/Fields/PresetField.tsx 100% <100%> (ø) ⬆️
...n-document-viewer-react/src/store/PreviewImages.ts 31.34% <50%> (-3.87%) ⬇️
...ges/sn-document-viewer-react/src/store/Document.ts 26.04% <50%> (-0.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19ffcd1...4eae44d. Read the comment docs.

@gallayl gallayl requested review from zoltanbedi and herflis February 1, 2019 11:55
zoltanbedi
zoltanbedi suggested changes Feb 6, 2019
View reviewed changes
Copy link
Contributor

@zoltanbedi zoltanbedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

examples/sn-dms-demo/src/store/documentlibrary/actions.ts Outdated Show resolved Hide resolved
examples/sn-dms-demo/src/store/usersandgroups/actions.ts Outdated Show resolved Hide resolved
examples/sn-react-redux-todo-app/src/reducers/todos.ts Outdated Show resolved Hide resolved
examples/sn-react-redux-todo-app/src/reducers/todos.ts Outdated Show resolved Hide resolved
packages/sn-controls-react/src/viewcontrols/BrowseView.tsx Outdated Show resolved Hide resolved
@gallayl gallayl merged commit 08da98a into develop Feb 8, 2019
@gallayl gallayl deleted the refactor/redux-store-cleanup branch February 8, 2019 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoltanbedi zoltanbedi zoltanbedi approved these changes

@herflis herflis Awaiting requested review from herflis

Assignees

@gallayl gallayl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gallayl @zoltanbedi