Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings initial steps #1159

Merged
merged 15 commits into from
Mar 10, 2021
Merged

Settings initial steps #1159

merged 15 commits into from
Mar 10, 2021

Conversation

enikonemeth
Copy link
Contributor

No description provided.

@enikonemeth enikonemeth added this to the Sprint 228 milestone Jan 26, 2021
@enikonemeth enikonemeth self-assigned this Jan 26, 2021
@sensenet
Copy link

sensenet bot commented Jan 26, 2021 •
edited
Loading

Site name Url Last deploy
sn-app-dev https://6047a81f27d2c90fb94612fe--sn-app-dev.netlify.app Tue Mar 09 2021 - 16:53:54 GMT+0000 (Coordinated Universal Time)
sn-react-component-docs-dev https://6047a8204ebfa1140bddc73c--sn-react-component-docs-dev.netlify.app Tue Mar 09 2021 - 16:53:53 GMT+0000 (Coordinated Universal Time)

@codecov
Copy link

codecov bot commented Jan 26, 2021 •
edited
Loading

Codecov Report

Merging #1159 (af101a7) into develop (6e4f278) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1159   +/-   ##
========================================
  Coverage    93.76%   93.76%           
========================================
  Files          232      232           
  Lines         6578     6578           
  Branches      1682     1682           
========================================
  Hits          6168     6168           
  Misses         410      410

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e4f278...af101a7. Read the comment docs.

@enikonemeth enikonemeth requested review from taki9 and herflis January 27, 2021 14:36
@enikonemeth enikonemeth marked this pull request as ready for review January 27, 2021 14:37
@herflis herflis removed this from the Sprint 228 milestone Feb 3, 2021
@enikonemeth enikonemeth requested a review from herflis February 25, 2021 14:14
taki9
taki9 reviewed Mar 3, 2021
View reviewed changes
apps/sensenet/src/components/drawer/PermanentDrawer.tsx Outdated Show resolved Hide resolved
apps/sensenet/src/components/settings/index.tsx Outdated Show resolved Hide resolved
apps/sensenet/src/components/settings/index.tsx Outdated Show resolved Hide resolved
apps/sensenet/src/components/drawer/PermanentDrawer.tsx Outdated Show resolved Hide resolved
apps/sensenet/src/hooks/use-drawer-items.tsx Outdated Show resolved Hide resolved
@enikonemeth enikonemeth requested a review from taki9 March 5, 2021 08:18
@herflis herflis merged commit f255bd1 into develop Mar 10, 2021
@herflis herflis deleted the feature/settings branch March 10, 2021 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@herflis herflis herflis approved these changes

@taki9 taki9 taki9 approved these changes

Assignees

@enikonemeth enikonemeth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@enikonemeth @herflis @taki9