Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API page of Settings menu #1168

Merged
merged 29 commits into from
Mar 17, 2021
Merged

API page of Settings menu #1168

merged 29 commits into from
Mar 17, 2021

Conversation

enikonemeth
Copy link
Contributor

No description provided.

@enikonemeth enikonemeth added this to the Sprint 228 milestone Feb 2, 2021
@enikonemeth enikonemeth self-assigned this Feb 2, 2021
@enikonemeth enikonemeth changed the base branch from develop to feature/settings February 2, 2021 11:43
@codecov
Copy link

codecov bot commented Feb 2, 2021 •
edited
Loading

Codecov Report

Merging #1168 (6c37bb3) into develop (53b5e0b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1168   +/-   ##
========================================
  Coverage    93.77%   93.77%           
========================================
  Files          232      232           
  Lines         6585     6585           
  Branches      1685     1685           
========================================
  Hits          6175     6175           
  Misses         410      410
Impacted Files Coverage Δ
...ent-core/src/Repository/RepositoryConfiguration.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53b5e0b...6c37bb3. Read the comment docs.

@sensenet
Copy link

sensenet bot commented Feb 2, 2021 •
edited
Loading

Site name Url Last deploy
sn-app-dev https://60520ce106e57798c1c02e5a--sn-app-dev.netlify.app Wed Mar 17 2021 - 14:06:26 GMT+0000 (Coordinated Universal Time)
sn-react-component-docs-dev https://60520cb43582c4b09b1153f8--sn-react-component-docs-dev.netlify.app Wed Mar 17 2021 - 14:05:40 GMT+0000 (Coordinated Universal Time)

@herflis herflis removed this from the Sprint 228 milestone Feb 3, 2021
Base automatically changed from feature/settings to develop March 10, 2021 08:15
@enikonemeth enikonemeth changed the title API page of Settings menu -WIP API page of Settings menu Mar 10, 2021
@enikonemeth enikonemeth marked this pull request as ready for review March 10, 2021 18:28
@enikonemeth enikonemeth added this to the Sprint 231 milestone Mar 10, 2021
@enikonemeth enikonemeth requested review from taki9 and herflis March 10, 2021 18:29
eniko.pusztai and others added 2 commits March 12, 2021 21:00
@enikonemeth enikonemeth requested a review from taki9 March 16, 2021 07:39
@herflis
Copy link
Contributor

herflis commented Mar 17, 2021

  1. Add a title to the icons here (javascript, .net, react, redux)
    image
  2. Please use a react icon with transparent background here (and it is now a bit compressed or something like that)

@herflis herflis removed this from the Sprint 231 milestone Mar 17, 2021
@enikonemeth enikonemeth requested a review from herflis March 17, 2021 09:09
@enikonemeth
Copy link
Contributor Author

  1. Add a title to the icons here (javascript, .net, react, redux)
    image
  2. Please use a react icon with transparent background here (and it is now a bit compressed or something like that)

DONE
image

@enikonemeth enikonemeth merged commit 3b1f618 into develop Mar 17, 2021
@enikonemeth enikonemeth deleted the feature/settings_api branch March 17, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@herflis herflis herflis approved these changes

@taki9 taki9 taki9 approved these changes

Assignees

@enikonemeth enikonemeth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@enikonemeth @herflis @taki9