Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced search #1180

Merged
merged 8 commits into from
Feb 17, 2021
Merged

Advanced search #1180

merged 8 commits into from
Feb 17, 2021

Conversation

taki9
Copy link
Contributor

@taki9 taki9 commented Feb 5, 2021

No description provided.

@taki9 taki9 requested review from herflis and enikonemeth February 5, 2021 16:26
@taki9 taki9 self-assigned this Feb 5, 2021
@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #1180 (b0dc1cd) into develop (53cbc51) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1180   +/-   ##
========================================
  Coverage    93.72%   93.73%           
========================================
  Files          232      232           
  Lines         6567     6574    +7     
  Branches      1683     1689    +6     
========================================
+ Hits          6155     6162    +7     
  Misses         412      412           
Impacted Files Coverage Δ
...s-react/src/components/tree-picker/tree-picker.tsx 97.91% <100.00%> (ø)
packages/sn-query/src/QueryExpression.ts 100.00% <100.00%> (ø)
packages/sn-query/src/QuerySegment.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53cbc51...b0dc1cd. Read the comment docs.

@sensenet
Copy link

sensenet bot commented Feb 5, 2021

Site name Url Last deploy
sn-app-dev https://602d122e20c7a500a50bd9ce--sn-app-dev.netlify.app Wed Feb 17 2021 - 12:55:11 GMT+0000 (Coordinated Universal Time)
sn-react-component-docs-dev https://602d123187e9ce014f99f377--sn-react-component-docs-dev.netlify.app Wed Feb 17 2021 - 12:55:15 GMT+0000 (Coordinated Universal Time)

Copy link
Contributor

@enikonemeth enikonemeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not save a search with the following data:
keyword: 'Sample',
modificationDate: 'today'

I got 'Unexpected end of JSON input' error, but response number 200 from backend, but saved queries was empty:

request payload:

{query: "(Name:'Sample*' OR DisplayName:'Sample*') AND (ModificationDate:>=@@Today@@)",…}
displayName: "Search results for 'Sample'"
query: "(Name:'Sample*' OR DisplayName:'Sample*') AND (ModificationDate:>=@@Today@@)"
queryType: "Public"
uiFilters: "{"term":"Sample","filters":{"type":{"name":"all","icon":{"type":{"type":{},"compare":null},"key":null,"ref":null,"props":{},"_owner":null}},"date":{"name":"modifiedToday","query":{"field":"ModificationDate","value":"@@Today@@"}},"reference":{"name":"anybody"}}}"

advances_search

Copy link
Contributor

@herflis herflis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • the clear button should have a tooltip
  • the clear button does not clear the value of the textbox
    search-clear
  • (after the clear button disappeared the save query button did not work either)
  • cannot navigate up in the picker from lower level containers

@taki9 taki9 marked this pull request as ready for review February 16, 2021 13:54
@herflis herflis self-requested a review February 17, 2021 07:28
@enikonemeth enikonemeth self-requested a review February 17, 2021 10:31
@enikonemeth enikonemeth merged commit dcc5f2b into develop Feb 17, 2021
@enikonemeth enikonemeth deleted the feature/advanced-search branch February 17, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants