Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor issues #1188

Merged
merged 5 commits into from
Mar 3, 2021
Merged

Fix minor issues #1188

merged 5 commits into from
Mar 3, 2021

Conversation

enikonemeth
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #1188 (23126ec) into develop (b78dfda) will increase coverage by 1.69%.
The diff coverage is 93.65%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1188      +/-   ##
===========================================
+ Coverage    92.07%   93.76%   +1.69%     
===========================================
  Files          216      232      +16     
  Lines         5942     6578     +636     
  Branches      1544     1681     +137     
===========================================
+ Hits          5471     6168     +697     
+ Misses         471      410      -61     
Impacted Files Coverage Δ
packages/sn-client-core/src/Repository/Preview.ts 97.56% <ø> (-0.12%) ⬇️
...ls-react/src/fieldcontrols/empty-field-control.tsx 100.00% <ø> (ø)
...ldcontrols/rich-text-editor/quill-oembed-module.ts 80.00% <ø> (ø)
packages/sn-controls-react/src/helpers.ts 81.81% <ø> (ø)
...ckages/sn-client-core/src/Repository/Repository.ts 97.46% <60.00%> (-1.24%) ⬇️
...s/sn-authentication-oidc-react/src/oidc-service.ts 88.23% <66.66%> (-5.10%) ⬇️
...ages/sn-controls-react/src/react-control-mapper.ts 92.85% <76.19%> (ø)
.../fieldcontrols/reference-grid/reference-picker.tsx 76.47% <76.47%> (ø)
...dcontrols/reference-grid/default-item-template.tsx 93.33% <83.33%> (ø)
...ls-react/src/fieldcontrols/allowed-child-types.tsx 88.80% <88.80%> (ø)
... and 190 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7c6641...23126ec. Read the comment docs.

@sensenet
Copy link

sensenet bot commented Feb 11, 2021

Site name Url Last deploy
sn-react-component-docs-dev https://603f3b5bc877c1e9d143e230--sn-react-component-docs-dev.netlify.app Wed Mar 03 2021 - 07:31:40 GMT+0000 (Coordinated Universal Time)
sn-app-dev https://603f3b9144fb8ec48e28b898--sn-app-dev.netlify.app Wed Mar 03 2021 - 07:32:37 GMT+0000 (Coordinated Universal Time)

Copy link
Contributor

@taki9 taki9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create unit tests for the new control

@enikonemeth enikonemeth requested a review from taki9 February 12, 2021 10:19
@herflis herflis removed this from the Sprint 229 milestone Feb 17, 2021
@enikonemeth enikonemeth merged commit d8e6688 into develop Mar 3, 2021
@enikonemeth enikonemeth deleted the fix/minor_issues branch March 3, 2021 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants