Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lazy load editor #1355

Merged
merged 4 commits into from
Jun 17, 2021
Merged

lazy load editor #1355

merged 4 commits into from
Jun 17, 2021

Conversation

taki9
Copy link
Contributor

@taki9 taki9 commented Jun 11, 2021

No description provided.

@taki9 taki9 requested review from herflis and enikonemeth June 11, 2021 09:51
@taki9 taki9 self-assigned this Jun 11, 2021
@sensenet
Copy link

sensenet bot commented Jun 11, 2021

Site name Url Last deploy
sn-app-dev https://60cb0ff97087dba6b095c1ec--sn-app-dev.netlify.app Thu Jun 17 2021 - 09:03:55 GMT+0000 (Coordinated Universal Time)
sn-react-component-docs-dev https://60cb0fe3e8c5debdf2bfb933--sn-react-component-docs-dev.netlify.app Thu Jun 17 2021 - 09:03:32 GMT+0000 (Coordinated Universal Time)

@codecov
Copy link

codecov bot commented Jun 14, 2021

Codecov Report

Merging #1355 (afb1ebc) into develop (bb7fe6a) will increase coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1355   +/-   ##
========================================
  Coverage    93.16%   93.16%           
========================================
  Files          231      232    +1     
  Lines         6441     6442    +1     
  Branches      1730     1730           
========================================
+ Hits          6001     6002    +1     
  Misses         440      440           
Impacted Files Coverage Δ
...n-controls-react/src/fieldcontrols/localization.ts 100.00% <ø> (ø)
...trols-react/src/fieldcontrols/rich-text-editor.tsx 86.48% <60.00%> (ø)
packages/sn-controls-react/src/editor-wrapper.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb7fe6a...afb1ebc. Read the comment docs.

@gatsby-cloud
Copy link

gatsby-cloud bot commented Jun 17, 2021

Gatsby Cloud Build Report

🚩 Your build failed. See the build logs here

@taki9 taki9 merged commit 35e7401 into develop Jun 17, 2021
@taki9 taki9 deleted the feature/editor_lazyload branch June 17, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants