Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table for editor #1371

Merged
merged 15 commits into from
Jul 13, 2021
Merged

Table for editor #1371

merged 15 commits into from
Jul 13, 2021

Conversation

taki9
Copy link
Contributor

@taki9 taki9 commented Jul 5, 2021

@taki9 taki9 requested a review from enikonemeth July 5, 2021 06:39
@taki9 taki9 self-assigned this Jul 5, 2021
@taki9 taki9 changed the title Feature/editor table Table for editor Jul 5, 2021
@sensenet
Copy link

sensenet bot commented Jul 5, 2021

Site name Url Last deploy
sn-app-dev https://60eda88e8f4cf65b4969b4c5--sn-app-dev.netlify.app Tue Jul 13 2021 - 14:52:01 GMT+0000 (Coordinated Universal Time)
sn-react-component-docs-dev https://60eda8975f8c665e038ffe33--sn-react-component-docs-dev.netlify.app Tue Jul 13 2021 - 14:52:10 GMT+0000 (Coordinated Universal Time)

@taki9 taki9 changed the base branch from develop to feature/editor_tests July 5, 2021 06:56
@codecov
Copy link

codecov bot commented Jul 5, 2021

Codecov Report

Merging #1371 (448a795) into develop (8f70c32) will decrease coverage by 0.43%.
The diff coverage is 70.89%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1371      +/-   ##
===========================================
- Coverage    92.71%   92.28%   -0.44%     
===========================================
  Files          244      246       +2     
  Lines         6714     6841     +127     
  Branches      1780     1817      +37     
===========================================
+ Hits          6225     6313      +88     
- Misses         489      528      +39     
Impacted Files Coverage Δ
...-editor-react/src/context/localization-context.tsx 100.00% <ø> (ø)
...es/sn-editor-react/src/components/context-menu.tsx 51.38% <51.38%> (ø)
...or-react/src/components/controls/table-control.tsx 88.88% <88.88%> (ø)
...tor-react/src/components/controls/link-control.tsx 92.10% <100.00%> (+0.43%) ⬆️
packages/sn-editor-react/src/components/editor.tsx 100.00% <100.00%> (ø)
...ckages/sn-editor-react/src/components/menu-bar.tsx 69.64% <100.00%> (+0.55%) ⬆️
packages/sn-editor-react/src/extension-list.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f70c32...448a795. Read the comment docs.

Base automatically changed from feature/editor_tests to develop July 7, 2021 13:59
Copy link
Contributor

@enikonemeth enikonemeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching between dark-light mode ruins the whole table 😢
dark

You have conflicts as well.

apps/sensenet/src/localization/hungarian.ts Outdated Show resolved Hide resolved
@taki9 taki9 merged commit 913d902 into develop Jul 13, 2021
@taki9 taki9 deleted the feature/editor_table branch July 13, 2021 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants