-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display all image previews in reference picker #1524
Display all image previews in reference picker #1524
Conversation
|
Nagyon Extra lett a fejlesztés. Nagyon gyorsan szerintem jó megoldást választottál. :D Átalakítottam egy picit. Annak érdekében, hogy könnyen bővíthető legyen kiszedtem a ternary operator és if-vel illetve guard clauses-rel oldottam meg.( A logika maradt ) Volt benne egy typscript hiba. Azt is javítottam. (Elötted is ott volt) Illetve ráraktam egy object fit: 'scale-down'-t a képre hogy eggyel jobban mutasson. |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1524 +/- ##
========================================
Coverage 92.51% 92.51%
========================================
Files 250 250
Lines 7050 7050
Branches 1914 1914
========================================
Hits 6522 6522
Misses 528 528
☔ View full report in Codecov by Sentry. |
…s://github.com/SenseNet/sn-client into Display-all-image-previews-in-reference-picker
No description provided.