Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to current content in reference picker #1534

Merged
merged 26 commits into from
Nov 21, 2023

Conversation

VargaJoe
Copy link
Contributor

@VargaJoe VargaJoe commented Oct 3, 2023

No description provided.

@VargaJoe VargaJoe requested a review from hassanad94 October 3, 2023 13:35
@sensenet
Copy link

sensenet bot commented Oct 3, 2023

Site name Url Last deploy
sn-app-dev https://655c86fd69db1c6a34ac587d--sn-app-dev.netlify.app Tue Nov 21 2023 - 10:31:25 GMT+0000 (Coordinated Universal Time)
sn-react-component-docs-dev https://655c87344ac8fd6b0c15ff8f--sn-react-component-docs-dev.netlify.app Tue Nov 21 2023 - 10:32:22 GMT+0000 (Coordinated Universal Time)

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9d9acc6) 92.52% compared to head (6f6bf2b) 92.54%.
Report is 1 commits behind head on develop.

Files Patch % Lines
...kers-react/src/components/picker/picker-helper.tsx 95.65% 1 Missing ⚠️
...s-react/src/components/tree-picker/tree-picker.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1534      +/-   ##
===========================================
+ Coverage    92.52%   92.54%   +0.01%     
===========================================
  Files          250      252       +2     
  Lines         7068     7125      +57     
  Branches      1915     1931      +16     
===========================================
+ Hits          6540     6594      +54     
- Misses         528      531       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hassanad94 hassanad94 marked this pull request as ready for review November 14, 2023 13:47
@hassanad94 hassanad94 requested a review from tusmester November 14, 2023 13:48
@VargaJoe VargaJoe merged commit f072985 into develop Nov 21, 2023
@VargaJoe VargaJoe deleted the feature/Shortcut-panel-in-reference-picker branch November 21, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants