Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and improve configuration page #1584

Merged
merged 6 commits into from
Nov 20, 2023
Merged

Conversation

kavics
Copy link
Contributor

@kavics kavics commented Nov 17, 2023

  • ".settings" postfix removed from the titles
  • "Learn more" href fixed.
  • "Learn more" links are displayed only if there is documentation for that setting (hardcoded whitelist).
  • "Delete" icon button added to the custom config files (hardcoded blacklist).

Copy link

sensenet bot commented Nov 17, 2023

Site name Url Last deploy
sn-app-dev https://655b2f898c6c876fa254fa2e--sn-app-dev.netlify.app Mon Nov 20 2023 - 10:06:02 GMT+0000 (Coordinated Universal Time)
sn-react-component-docs-dev https://655b2fc451cc1b6f873ba266--sn-react-component-docs-dev.netlify.app Mon Nov 20 2023 - 10:07:01 GMT+0000 (Coordinated Universal Time)

Copy link

sensenet bot commented Nov 17, 2023

Site name Url Last deploy
sn-app-dev https://6556cd4fd3a2173982f0e427--sn-app-dev.netlify.app Fri Nov 17 2023 - 02:17:56 GMT+0000 (Coordinated Universal Time)
sn-react-component-docs-dev https://6556cd50ea424e3b0a809176--sn-react-component-docs-dev.netlify.app Fri Nov 17 2023 - 02:17:55 GMT+0000 (Coordinated Universal Time)

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8d97b92) 92.52% compared to head (3f0eb17) 92.52%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1584   +/-   ##
========================================
  Coverage    92.52%   92.52%           
========================================
  Files          250      250           
  Lines         7068     7068           
  Branches      1915     1915           
========================================
  Hits          6540     6540           
  Misses         528      528           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kavics kavics merged commit 9d9acc6 into develop Nov 20, 2023
@kavics kavics deleted the feat/1988-cleanup-config-page branch November 20, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants