Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/addbutton change #520

Merged
merged 15 commits into from
Jan 7, 2020
Merged

Feature/addbutton change #520

merged 15 commits into from
Jan 7, 2020

Conversation

enikonemeth
Copy link
Contributor

It is working what I expected, but we have 2 differences compare to the previous version:

@enikonemeth enikonemeth self-assigned this Dec 16, 2019
@codecov
Copy link

codecov bot commented Dec 16, 2019

Codecov Report

Merging #520 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #520   +/-   ##
========================================
  Coverage    91.16%   91.16%           
========================================
  Files          191      191           
  Lines         5208     5208           
  Branches      1292     1292           
========================================
  Hits          4748     4748           
  Misses         460      460

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e588eb...000aab6. Read the comment docs.

@sensenet
Copy link

sensenet bot commented Dec 16, 2019

Site name Url Last deploy
sn-react-component-docs-dev https://5e145dd1d200cc02f3966a6f--sn-react-component-docs-dev.netlify.com Tue Jan 07 2020 - 10:30:42 GMT+0000 (Coordinated Universal Time)
sn-app-dev https://5e145dbf7672dd43182744ef--sn-app-dev.netlify.com Tue Jan 07 2020 - 10:30:24 GMT+0000 (Coordinated Universal Time)
sn-dms-demo-dev https://5e145de474ead81de80ea1bd--sn-dms-demo-dev.netlify.com Tue Jan 07 2020 - 10:31:01 GMT+0000 (Coordinated Universal Time)

@herflis
Copy link
Contributor

herflis commented Dec 16, 2019

@pusztaienike sorry, I forgot to mention that in case of ContentTypes the Action that should be available is not 'Add' but 'Upload'

@enikonemeth
Copy link
Contributor Author

@pusztaienike sorry, I forgot to mention that in case of ContentTypes the Action that should be available is not 'Add' but 'Upload'

For Content type I had to track the queryData cause it has an allowedChildTypes attribute, what I needed for the Action list...
Changes have been made. It is working now for Content types as well

apps/sensenet/src/components/AddButton.tsx Outdated Show resolved Hide resolved
apps/sensenet/src/components/AddButton.tsx Outdated Show resolved Hide resolved
apps/sensenet/src/components/AddButton.tsx Outdated Show resolved Hide resolved
apps/sensenet/src/components/AddButton.tsx Outdated Show resolved Hide resolved
apps/sensenet/src/components/AddButton.tsx Outdated Show resolved Hide resolved
This was referenced Dec 23, 2019
apps/sensenet/src/components/AddButton.tsx Outdated Show resolved Hide resolved
apps/sensenet/src/components/drawer/PermanentDrawer.tsx Outdated Show resolved Hide resolved
apps/sensenet/src/components/drawer/PermanentDrawer.tsx Outdated Show resolved Hide resolved
apps/sensenet/src/components/drawer/PermanentDrawer.tsx Outdated Show resolved Hide resolved
apps/sensenet/src/components/drawer/PermanentDrawer.tsx Outdated Show resolved Hide resolved
apps/sensenet/src/components/drawer/PermanentDrawer.tsx Outdated Show resolved Hide resolved
apps/sensenet/src/hooks/use-drawer-items.tsx Outdated Show resolved Hide resolved
@enikonemeth enikonemeth requested a review from zoltanbedi January 6, 2020 13:21
@enikonemeth enikonemeth requested a review from zoltanbedi January 7, 2020 10:24
Copy link
Contributor

@zoltanbedi zoltanbedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥾

Copy link
Contributor

@herflis herflis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐱‍🏍

@enikonemeth enikonemeth merged commit eb96016 into develop Jan 7, 2020
@enikonemeth enikonemeth deleted the feature/addbutton_change branch January 7, 2020 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants