Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert webpack config to prod and dev #532

Merged
merged 8 commits into from
Jan 8, 2020

Conversation

zoltanbedi
Copy link
Contributor

@zoltanbedi zoltanbedi commented Jan 5, 2020

Raw numbers from network tab:

Site name Transfered data Resources size Page load finish DOMContentLoaded Requests
https://sn-app-dev.netlify.com/login 12.7 MB 57.3 MB 1.1 min 57.56 s 18
https://5e124719629c8f3c3842fe9f--sn-app-dev.netlify.com/login 4.3 MB 8.1 MB 2.18 s 909 ms 16

Lighthouse test:

https://sn-app-dev.netlify.com/login

https://5e124719629c8f3c3842fe9f--sn-app-dev.netlify.com/login

Wired in relative ci to follow bundle size. Our project https://app.relative-ci.com/projects/SpRCK0ViJsBVzSUtpFtk

  • change the netlify site Publish directory to apps/sensenet/build when merged

@zoltanbedi zoltanbedi force-pushed the feature/webpack-config-update branch from 1443726 to 3b795c4 Compare January 5, 2020 20:12
@sensenet
Copy link

sensenet bot commented Jan 5, 2020

Site name Url Last deploy
sn-app-dev https://5e159291e5f96b07c42b72b1--sn-app-dev.netlify.com Wed Jan 08 2020 - 08:28:03 GMT+0000 (Coordinated Universal Time)
sn-react-component-docs-dev https://5e15924eba14c71df227cfd8--sn-react-component-docs-dev.netlify.com Wed Jan 08 2020 - 08:26:55 GMT+0000 (Coordinated Universal Time)
sn-dms-demo-dev https://5e15924ee7054f6ff5c5b926--sn-dms-demo-dev.netlify.com Wed Jan 08 2020 - 08:26:54 GMT+0000 (Coordinated Universal Time)

@codecov
Copy link

codecov bot commented Jan 5, 2020

Codecov Report

Merging #532 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #532   +/-   ##
========================================
  Coverage    91.16%   91.16%           
========================================
  Files          191      191           
  Lines         5208     5208           
  Branches      1292     1292           
========================================
  Hits          4748     4748           
  Misses         460      460

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23434f6...6d533c1. Read the comment docs.

@zoltanbedi zoltanbedi self-assigned this Jan 6, 2020
apps/sensenet/webpack.common.js Outdated Show resolved Hide resolved
apps/sensenet/webpack.dev.js Outdated Show resolved Hide resolved
@zoltanbedi zoltanbedi force-pushed the feature/webpack-config-update branch from 2b92596 to 23434f6 Compare January 7, 2020 14:25
@zoltanbedi zoltanbedi merged commit 3e271bd into develop Jan 8, 2020
@zoltanbedi zoltanbedi deleted the feature/webpack-config-update branch January 8, 2020 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants