Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/docviewer toolbar #702

Merged
merged 13 commits into from
Jun 12, 2020
Merged

Fix/docviewer toolbar #702

merged 13 commits into from
Jun 12, 2020

Conversation

herflis
Copy link
Contributor

@herflis herflis commented Jun 11, 2020

  • zoommode widget is removed from the admin-ui docviewer
  • missing titles and string resources is added to the remaining zoom buttons
  • RotateActivePage and RotateDocument widgets are now configurable, you can set which buttons should be displayed
  • on the admin-ui the mode on the above mentioned to widgets is set to clockwise to display only two buttons

@sensenet
Copy link

sensenet bot commented Jun 11, 2020

Site name Url Last deploy
sn-react-component-docs-dev https://5ee39c7e00c1fe58d005a4d0--sn-react-component-docs-dev.netlify.app Fri Jun 12 2020 - 15:17:19 GMT+0000 (Coordinated Universal Time)
sn-app-dev https://5ee39c806dd7c3ffa089da9a--sn-app-dev.netlify.app Fri Jun 12 2020 - 15:17:24 GMT+0000 (Coordinated Universal Time)

@codecov
Copy link

codecov bot commented Jun 11, 2020

Codecov Report

Merging #702 into develop will increase coverage by 0.02%.
The diff coverage is 97.43%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #702      +/-   ##
===========================================
+ Coverage    92.27%   92.29%   +0.02%     
===========================================
  Files          214      214              
  Lines         5749     5779      +30     
  Branches      1450     1466      +16     
===========================================
+ Hits          5305     5334      +29     
- Misses         444      445       +1     
Impacted Files Coverage Δ
...-viewer-react/src/context/localization-context.tsx 100.00% <ø> (ø)
...eact/src/components/document-widgets/ZoomInOut.tsx 46.15% <50.00%> (-3.85%) ⬇️
.../components/document-widgets/RotateActivePages.tsx 100.00% <100.00%> (ø)
...src/components/document-widgets/RotateDocument.tsx 100.00% <100.00%> (ø)
...r-react/src/components/page-widgets/RotatePage.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7da66f1...7dc12c5. Read the comment docs.

@herflis herflis requested review from enikonemeth and taki9 June 11, 2020 16:49
Copy link
Contributor

@enikonemeth enikonemeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@herflis herflis merged commit 9e3e57d into develop Jun 12, 2020
@herflis herflis deleted the fix/docviewer-toolbar branch June 12, 2020 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants