Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protected sn routes & custom content pages #707

Merged
merged 9 commits into from
Jun 29, 2020
Merged

Protected sn routes & custom content pages #707

merged 9 commits into from
Jun 29, 2020

Conversation

taki9
Copy link
Contributor

@taki9 taki9 commented Jun 17, 2020

No description provided.

@taki9 taki9 self-assigned this Jun 17, 2020
@taki9 taki9 requested review from enikonemeth and herflis June 17, 2020 14:36
@codecov
Copy link

codecov bot commented Jun 17, 2020

Codecov Report

Merging #707 into develop will decrease coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #707      +/-   ##
===========================================
- Coverage    92.31%   92.29%   -0.02%     
===========================================
  Files          214      214              
  Lines         5800     5803       +3     
  Branches      1465     1467       +2     
===========================================
+ Hits          5354     5356       +2     
- Misses         446      447       +1     
Impacted Files Coverage Δ
...s/sn-pickers-react/src/ListPicker/useListPicker.ts 95.00% <ø> (ø)
...ackages/sn-pickers-react/src/ListPicker/loaders.ts 96.55% <66.66%> (-3.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e46a1f...3b977ee. Read the comment docs.

@sensenet
Copy link

sensenet bot commented Jun 17, 2020

Site name Url Last deploy
sn-app-dev https://5ef9ea9d4e85306fa59a03fa--sn-app-dev.netlify.app Mon Jun 29 2020 - 13:20:32 GMT+0000 (Coordinated Universal Time)
sn-react-component-docs-dev https://5ef9ea9d5cef1501da4965bd--sn-react-component-docs-dev.netlify.app Mon Jun 29 2020 - 13:20:31 GMT+0000 (Coordinated Universal Time)

case 'Setup':
return <Build />
case 'CustomContent':
return <Folder />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return <Folder />
return item.settings && item.settings.icon ? (
<Icon item={{ ContentTypeName: item.settings.icon }} />
) : (
<Folder/>
)

Copy link
Contributor

@enikonemeth enikonemeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the command palette default options two links are not working:
Content and Events.

@herflis
Copy link
Contributor

herflis commented Jun 24, 2020

There was a setting on drawer items where the users could set which columns should be displayed on the grid
{
"itemType": "Content",
"settings": {
"description": "Explore your content",
"icon": "Workspace",
"title": "Content",
"columns": ["DisplayName", "ModifiedBy", "ModificationDate"],
"browseType": "explorer",
"root": "/Root"
}
}

It would be awesome to add/keep this functionality in the new solution if it is not a huge work 🙂

@herflis herflis merged commit 2eadcda into develop Jun 29, 2020
@herflis herflis deleted the routing_refact branch June 29, 2020 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants