Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permission related redux actions #721

Merged
merged 12 commits into from
Jun 29, 2020
Merged

Permission related redux actions #721

merged 12 commits into from
Jun 29, 2020

Conversation

herflis
Copy link
Contributor

@herflis herflis commented Jun 23, 2020

  • security.setPermissions action's requestbody param in client-core is changed from object to array because the required format is this:
{r:[{identity:"/Root/IMS/BuiltIn/Portal/Visitor", OpenMinor:"allow", Save:"deny"},
{identity:"/Root/IMS/BuiltIn/Portal/Creators", Custom16:"A", Custom17:"1"}]}
  • setPermissionInheritance method is removed, its functionality is moved to setPermissions as a param

  • hasPermission, getPermissions and setPermissions redux actions and related tests are added

  • action for permission queries are also added

@codecov
Copy link

codecov bot commented Jun 23, 2020

Codecov Report

Merging #721 into develop will increase coverage by 0.01%.
The diff coverage is 96.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #721      +/-   ##
===========================================
+ Coverage    92.29%   92.31%   +0.01%     
===========================================
  Files          214      214              
  Lines         5779     5800      +21     
  Branches      1463     1468       +5     
===========================================
+ Hits          5334     5354      +20     
- Misses         445      446       +1     
Impacted Files Coverage Δ
packages/sn-redux/src/Actions.ts 95.20% <95.65%> (+0.07%) ⬆️
packages/sn-client-core/src/Repository/Security.ts 100.00% <100.00%> (ø)
...c-react/src/components/authentication-provider.tsx 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93ee4e2...bf64478. Read the comment docs.

@sensenet
Copy link

sensenet bot commented Jun 23, 2020

Site name Url Last deploy
sn-react-component-docs-dev https://5ef9dd51113178b17bbb0b96--sn-react-component-docs-dev.netlify.app Mon Jun 29 2020 - 12:23:46 GMT+0000 (Coordinated Universal Time)
sn-app-dev https://5ef9dd4b10c32f33ab274268--sn-app-dev.netlify.app Mon Jun 29 2020 - 12:23:39 GMT+0000 (Coordinated Universal Time)

@herflis herflis requested review from enikonemeth and taki9 June 23, 2020 19:25
Copy link
Contributor

@enikonemeth enikonemeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌵

@herflis herflis merged commit 3e46a1f into develop Jun 29, 2020
@herflis herflis deleted the redux/permission-actions branch June 29, 2020 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants