-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FixAmmoSprite #1686
FixAmmoSprite #1686
Conversation
RSI Diff Bot; head commit 635eedd merging into 1677950 Resources/Textures/Objects/Weapons/Guns/Ammunition/Boxes/anti_materiel.rsi
Resources/Textures/Objects/Weapons/Guns/Ammunition/Boxes/caseless_rifle.rsi
Resources/Textures/Objects/Weapons/Guns/Ammunition/Boxes/light_rifle.rsi
Resources/Textures/Objects/Weapons/Guns/Ammunition/Boxes/magnum.rsi
Resources/Textures/Objects/Weapons/Guns/Ammunition/Boxes/pistol.rsi
Resources/Textures/Objects/Weapons/Guns/Ammunition/Boxes/rifle.rsi
Resources/Textures/Objects/Weapons/Guns/Ammunition/Magazine/CaselessRifle/caseless_rifle_mag.rsi
Resources/Textures/Objects/Weapons/Guns/Ammunition/Magazine/CaselessRifle/caseless_rifle_mag_short.rsi
Resources/Textures/Objects/Weapons/Guns/Ammunition/Magazine/LightRifle/light_rifle_mag.rsi
Resources/Textures/Objects/Weapons/Guns/Ammunition/Magazine/LightRifle/maxim.rsi
Resources/Textures/Objects/Weapons/Guns/Ammunition/Magazine/Magnum/magnum_smg_mag.rsi
Resources/Textures/Objects/Weapons/Guns/Ammunition/Magazine/Rifle/rifle_mag.rsi
Resources/Textures/Objects/Weapons/Guns/Ammunition/Magazine/Shotgun/m12.rsi
Resources/Textures/SS220/Objects/Weapons/Guns/Ammunition/Magazine/MagazineUssp_RPK.rsi
Resources/Textures/SS220/Objects/Weapons/Guns/Ammunition/Magazine/ussp_magppsh.rsi
|
@EstKemran жду аппрув |
@yulilok На все изменения вне нашей репы нужно поставить пометки |
- state: base-6 #ss-220 sprite fix | ||
map: [ "enum.GunVisualLayers.Mag" ] | ||
- type: MagazineVisuals | ||
magState: base #ss-220 sprite fix | ||
steps: 7 | ||
zeroVisible: false | ||
- type: Appearance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Тут добавляется не одна строка, поэтому нужно будет сделать пометки через begin-end. Например:
#SS220-FixAmmoSprite-Begin
Новые строки
#SS220-FisAmmoSprite-End
Пометка типаsprite fix
не подойдёт. Пометка должна указывать на твой PR или commit, чтобы понять, что за изменения, откуда оно и т.д.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
как подметил Кемран, добавить пометки на все измеения вне папок 220
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
написать пометки на всех изменениях вне наших папок
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
пометка кемрана?
Описание PR
Была исправлена ошибка в отображении патронов в коробке/ящике/магазине, также было добавлено отображение патронов в пустых магазинах.
fixes: #1179
Медиа
https://github.com/user-attachments/assets/78c3cb3a-91c9-4915-924c-440eff588086
Проверки
Изменения
🆑 yulilok