Userland: Port some applications to the GML compiler #25637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
RatcheT2497
force-pushed
the
various-gml-compilation-ports
branch
2 times, most recently
from
06eb4fe to
1b593da
Compare
RatcheT2497
force-pushed
the
various-gml-compilation-ports
branch
from
1b593da to
0e87322
Compare
MacDue
reviewed
Jan 12, 2025
| @@ -174,11 +164,11 @@ void ThemesSettingsWidget::apply_settings() | |||
| auto color_scheme_path = color_scheme_path_or_error.release_value(); | |||
|
|
|||
| if (!m_color_scheme_is_file_based && find_descendant_of_type_named<GUI::CheckBox>("custom_color_scheme_checkbox")->is_checked()) { | |||
| auto set_theme_result = GUI::ConnectionToWindowServer::the().set_system_theme(m_selected_theme->path, m_selected_theme->name, m_background_settings_changed, "Custom"sv); | |||
There was a problem hiding this comment.
Why is m_background_settings_changed hardcoded to false now?
There was a problem hiding this comment.
I hardcoded it because it was always set to false at the very start of the method unconditionally, which (at least as far as I know) rendered it pretty much moot. It was a reference that BackgroundSettingsWidget set at various points and there currently doesn't seem to be a standardized way of passing variables to compiled widgets either, but it wouldn't make much of a difference.
EDIT: For what it's worth, I tested it a little after removing the forced reset and it didn't seem to do much of anything, so I'm not really sure what's it meant to do...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contributes towards #20518
The ported applications are: ThemeEditor, DisplaySettings and ClockSettings.