Simplify HasAccessibleTypeWithMetadataName #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergio0694
force-pushed
the
dev/simplify-HasAccessibleTypeWithMetadataName
branch
from
2d5492f to
18a8aa2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR simplifies
HasAccessibleTypeWithMetadataNameto use the built-inIsSymbolAccessibleWithinmethod, rather than having extra custom logic to manually check the accessibility of types and then to see whether they were accessible.cc. @Youssef1313 @333fred @CyrusNajmabadi could you take a look when you have a minute? 😄
I could use a second pair of eyes to double check the change is actually valid and with the same semantics.