Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecesary throws #120

Closed
lprone opened this issue Feb 9, 2019 · 2 comments
Closed

Unnecesary throws #120

lprone opened this issue Feb 9, 2019 · 2 comments

Comments

@lprone
Copy link

lprone commented Feb 9, 2019

https://github.com/T145/JTerm/blob/49816ce060eeecf2429caa41609c9d71bfaa1d06/src/main/java/jterm/io/input/RawConsoleInput.java#L132

This exception it's already catched inside the method
@jainrish
Copy link

jainrish commented Mar 8, 2019

I want to work on this. Let me know if I can take this up.

@sananta
Copy link
Contributor

sananta commented Apr 27, 2019

Addressed this issue: #121

T145 added a commit that referenced this issue May 14, 2019
@T145
Merge pull request #121 from sananta/remove-unnecessary-throws
7296d35 
Removed unnecessary throws in initWindows function #120
@T145 T145 closed this as completed Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@T145 @lprone @jainrish @sananta