Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set node by name #73

Merged
merged 22 commits into from
Oct 31, 2024
Merged

Set node by name #73

Show file tree
Hide file tree
Changes from 19 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
fdc35d0
switch nodes by name not the position. Move next node selection mecha…
ollmer Oct 25, 2024
912dae3
use node names in gaia and workarena examples
ollmer Oct 25, 2024
106c271
fix
ollmer Oct 25, 2024
ca635e1
node names in team agent
ollmer Oct 25, 2024
0b2da16
fix next node view
ollmer Oct 25, 2024
e40965b
update workarena test
ollmer Oct 25, 2024
0360893
set prompt_id in run_iteration
ollmer Oct 28, 2024
bda4cc6
improve reuse test
ollmer Oct 28, 2024
6fae9a7
update gsm8k example
ollmer Oct 28, 2024
51b2961
compute next and last nodes in view during step add
ollmer Oct 28, 2024
3fcf701
cleaner tests outputs
ollmer Oct 28, 2024
b2785c1
update test res
ollmer Oct 28, 2024
3ec3163
set last node correctly
ollmer Oct 28, 2024
477d539
tests for new select_node logic
ollmer Oct 28, 2024
a5f0ef5
update intro with call by names
ollmer Oct 29, 2024
da876fc
update intro
ollmer Oct 29, 2024
af49e35
Merge branch 'main' into set_node_by_name
ollmer Oct 29, 2024
93c0a23
update intro after merge
ollmer Oct 29, 2024
b7140ac
reuse activ agent check in view
ollmer Oct 29, 2024
7fd9b89
address review comments
ollmer Oct 31, 2024
9ed5550
Merge branch 'main' into set_node_by_name
ollmer Oct 31, 2024
23224a8
update tape improver test res
ollmer Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions assets/failed_tape.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
},
{
"kind": "set_next_node",
"next_node": 1,
"next_node": "act",
"metadata": {
"agent": "Agent",
"node": "",
Expand Down Expand Up @@ -85,7 +85,7 @@
},
{
"kind": "set_next_node",
"next_node": 1,
"next_node": "act",
"metadata": {
"agent": "Agent",
"node": "",
Expand Down Expand Up @@ -122,7 +122,7 @@
},
{
"kind": "set_next_node",
"next_node": 1,
"next_node": "act",
"metadata": {
"agent": "Agent",
"node": "",
Expand Down
36 changes: 23 additions & 13 deletions examples/gaia_agent/agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,24 +123,34 @@ def prepare_guidance(cls, planning_mode: PlanningMode, subtasks: bool) -> list[G
GaiaNode(name="plan", guidance=PromptRegistry.plan),
GaiaNode(name="facts_survey", guidance=PromptRegistry.facts_survey),
GaiaNode(name="start_execution", guidance=PromptRegistry.start_execution),
GaiaNode(name="default", next_node=3),
GaiaNode(name="default", next_node="default"),
]
elif planning_mode == PlanningMode.reflect:
guidance_nodes = [
GaiaNode(name="plan", guidance=PromptRegistry.plan),
GaiaNode(name="facts_survey", guidance=PromptRegistry.facts_survey),
GaiaNode(name="start_execution", guidance=PromptRegistry.start_execution, next_node=6),
GaiaNode(name="think_after_observation", guidance=PromptRegistry.think_after_observation, next_node=6),
GaiaNode(name="think_after_calculation", guidance=PromptRegistry.think_after_calculation, next_node=6),
GaiaNode(name="default", next_node=6),
GaiaNode(
name="start_execution", guidance=PromptRegistry.start_execution, next_node="after_observation"
),
GaiaNode(
name="think_after_observation",
guidance=PromptRegistry.think_after_observation,
next_node="after_observation",
),
GaiaNode(
name="think_after_calculation",
guidance=PromptRegistry.think_after_calculation,
next_node="after_observation",
),
GaiaNode(name="default", next_node="after_observation"),
ObservationControlNode(
name="node_after_observation",
name="after_observation",
observation_to_node={
PageObservation: 3,
SearchResultsObservation: 3,
CalculationResultObservation: 4,
PageObservation: "think_after_observation",
SearchResultsObservation: "think_after_observation",
CalculationResultObservation: "think_after_calculation",
},
default_node=5,
default_node="default",
),
]
elif planning_mode == PlanningMode.facts_and_sources:
Expand All @@ -149,23 +159,23 @@ def prepare_guidance(cls, planning_mode: PlanningMode, subtasks: bool) -> list[G
GaiaNode(name="facts_survey", guidance=PromptRegistry.facts_survey),
GaiaNode(name="sources_plan", guidance=PromptRegistry.sources_plan),
GaiaNode(name="start_execution", guidance=PromptRegistry.start_execution),
GaiaNode(name="default", next_node=4),
GaiaNode(name="default", next_node="default"),
]
elif planning_mode == PlanningMode.multiplan:
guidance_nodes = [
GaiaNode(name="plan", guidance=PromptRegistry.plan3),
GaiaNode(name="facts_survey", guidance=PromptRegistry.facts_survey),
GaiaNode(name="sources_plan", guidance=PromptRegistry.sources_plan),
GaiaNode(name="start_execution", guidance=PromptRegistry.start_execution),
GaiaNode(name="default", next_node=4),
GaiaNode(name="default", next_node="default"),
]
elif planning_mode == PlanningMode.replan_after_sources:
guidance_nodes = [
GaiaNode(name="plan", guidance=PromptRegistry.plan),
GaiaNode(name="facts_survey", guidance=PromptRegistry.facts_survey),
GaiaNode(name="better_plan", guidance=PromptRegistry.better_plan),
GaiaNode(name="start_execution", guidance=PromptRegistry.start_execution),
GaiaNode(name="default", next_node=4),
GaiaNode(name="default", next_node="default"),
]
else:
raise ValueError(f"Unknown planning mode: {planning_mode}")
Expand Down
2 changes: 1 addition & 1 deletion examples/gsm8k_tuning/math_agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ def create(cls, llm: LLM):
steps_prompt=ALLOWED_STEPS,
agent_step_cls=MathAgentStep,
guidance=HINTS,
next_node=-1,
next_node="default",
),
],
max_iterations=2,
Expand Down
Loading