Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zend From File Count Validation #10

Closed
starkskalle opened this issue Aug 1, 2019 · 7 comments
Closed

Zend From File Count Validation #10

starkskalle opened this issue Aug 1, 2019 · 7 comments

Comments

@starkskalle
Copy link

Hey,

I cannot provide any more information at the moment but the issue seems to be pretty straight forward:

'count(): Parameter must be an array or an object that implements Countable' in file '/vendor/shardj/zf1-future/library/Zend/Validate/File/Count.php' on line '257'

Running on PHP 7.3.

Let me know if you need any more info.

Thanks

@Shardj
Copy link
Owner

Shardj commented Aug 1, 2019

Thanks, I thought I got all of these but it seems like I missed this one. I'll get it sorted

@Shardj
Copy link
Owner

Shardj commented Aug 1, 2019

7b15f33

Tell me if you want a new tag or anything

@Shardj Shardj closed this as completed Aug 1, 2019
@starkskalle
Copy link
Author

Thanks for the quick action! Is there any way to consume this specific commit via composer so I can give it a try?

@Shardj
Copy link
Owner

Shardj commented Aug 1, 2019

"require": {
"shardj/zf1-future": "dev-master#7b15f33d9fe20e13d59501f14a121a6e514837b6"
}

That would work, but I'll just go make a new version for you so that as long as you're asking for the latest version with composer you'll get it.

@Shardj
Copy link
Owner

Shardj commented Aug 1, 2019

I've created a new tag release-1.14.2 so you should just be able to use that

@starkskalle
Copy link
Author

I tried it with locally updated source files and the fix works. However I might prefer a bit to change the line 90 to instead. But it does not make any big difference :-)
protected $_files = [];

@starkskalle
Copy link
Author

Sweet, just updating to the new tag release-1.14.2, thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants