-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Zend_Rest_Route::assemble signature #1
Conversation
Make the Zend_Rest_Route::assemble signature match Zend_Controller_Router_Route_Module::assemble as needed by php 7.2.
Sorry for bugging you, I'm now focusing my efforts on the subtree splits in https://github.com/zf1s. Thanks for your time. |
Thanks for bringing it up, I'll have a look later |
@hairmare would you recommend migration from my branch here to using needed modules from https://github.com/zf1s instead? The company I work for has a privately maintained branch from this repo here and we've been looking for a publicly maintained branch to use instead. |
@Shardj I seem to be the second contributor to the zf1s orga. If you join it looks like that would make three of us. Using an install that is split into multiple subpackages should make it easier to migrate away from zf1 since you can start removing the bit and pieces you don't use on a module by module base. The app I'm still maintaining that uses zf1 is only on our intranet and I would recommend to not use zf1 in any web-facing capacity at this point. |
@hairmare I'm devops for a webapp which started development in 2013 using zf1, its massive and very public. The companies only product. Keeping it as up to date as possible while moving away from zf1 (to zf3 most likely) is the plan. We do have namespaces, DI, and now PHP 7.2 so it isn't all so bad. And the codebase is pretty well organised. I'll probably move us over to zf1s too since it does seem to be a better approach. |
…incompatibilities_by_notifications Dtportal 14813 handling php72 incompatibilities by notifications
Added auto translate for Form Element getDescription
Merge upstream zf1-future changes into our forked branch
… ($string) of type string is deprecated
…string is deprecated"
…string is deprecated"
…of type string is deprecated in /Zend/Locale/Data.php
Fix deprecation message like that 'Passing null to parameter Shardj#1 () of type string is deprecated'
Fix deprecation message like that 'Passing null to parameter Shardj#1 () of type string is deprecated'
Fix deprecation message like that 'Passing null to parameter Shardj#1 () of type string is deprecated'
Fix deprecation message like that 'Passing null to parameter Shardj#1 () of type string is deprecated'
Fix deprecation message like that 'Passing null to parameter Shardj#1 () of type string is deprecated'
Fix deprecation message like that 'Passing null to parameter Shardj#1 () of type string is deprecated'
Fix deprecation message like that 'Passing null to parameter Shardj#1 () of type string is deprecated'
Fix deprecation message like that 'Passing null to parameter Shardj#1 () of type string is deprecated'
Fix deprecation message like that 'Passing null to parameter Shardj#1 () of type string is deprecated'
…ecated issue (#269) * Add github action ci step, run phpunit on php 8.1 * php 8.1, Fix Deprecations Fix deprecation message like that 'Passing null to parameter #1 () of type string is deprecated' * php 8.1 fix issue, Deprecated: current(): Calling current() on an object is deprecated" * php81 - fix date_sunset() is deprecated, date_sunrise() is deprecated on php 8.1 use date_sun_info() instead of date_sunset(), date_sunrise() other case backwards compatible with php < 8.1 * php81 - Zend_DateTest::testSunFunc add code support php 8.1
* phpunit - Skip test use method mcrypt_* on php >= 7.1 mcrypt_* function has been DEPRECATED as of PHP 7.1.0 and REMOVED as of PHP 7.2.0. Relying on this function is highly discouraged. * phpunit - skip run Openssl test on php >= 8.0 since php 8.0 will raise something like that 'ArgumentCountError: openssl_seal() expects at least 5 arguments, 4 given' * phpunit - ignore temp file make by test * phpunit - comment out Zend_CurrencyTest suite * phpunit - comment out Zend_Crypt_MathTest Suite * php 8.1 - fix deprecated message TypeError: count(): Argument #1 () must be of type Countable|array, null given PHP Deprecated: DOMDocument::__construct(): Passing null to parameter #2 () of type string is deprecated * phpunit - correctly Zend_Feed_* test suite and turn on Zend_Feed_AllTests suite * phpunit - back compatibility exception message for php < 8.0 * git - ignore temp file make by unittest * phpunit - back compatibility exception message for php < 8.0 for Zend_ProgressBar_Adapter_ConsoleTest * php <= 7.4 - fix warning 'A non well formed numeric value encountered' * github action - add step run phpunit on php 7.4 * github action - run phpunit on php 8.1, 8.0, 8.4 parallel
Fixed: TypeError: round(): Argument #1 ($num) must be of type int|float
Fixes deprecation message when running on php8 `Deprecated: realpath(): Passing null to parameter #1 ($path) of type string is deprecated i`
Added TLS v1.3 protocol
This is a step in the direction of making more of this work with php 7.2.
It gets rid of the
Declaration of Zend_Rest_Route::assemble($data = Array, $reset = false, $encode = true) must be compatible with Zend_Controller_Router_Route_Module::assemble($data = Array, $reset = false, $encode = true, $partial = false)
exception thrown when loading the rest module. It is backwards compatible with previously supported versions of php.I'll probably have some more changes pertaining to php 7.2 since it is finally becoming the standard on most distros. Are you accepting patches on/maintaining this fork?