Handling \Throwable in error controller

[tomasfejfar]

There are multiple places where Exception is caught instead of \Throwable. This causes that if any such code inside those method throws TypeError such error is not handled in the expected way. There was already some code around action ErrorExceptions, but there was no code regarding ErrorExceptions from plugins.

This PR replaces all those places and also adds test that checks that TypeException is correctly propagated.

[Jimbolino]

These tests would fail on older versions of php right?

[tomasfejfar]

Yes, especially on versions that don't have return types (i.e. <7.0). Maybe they could be mark as skipped based on PHP version... what do you think?

[Jimbolino]

Now i think about it, the rest of the code would also fail on php < 7.0

I havent tried it, but i read that this is the backwards compatible way to do it:

try {
    // Code that may throw an Exception or Error.
} catch (Throwable $t) {
    // Executed only in PHP 7, will not match in PHP 5.x
} catch (Exception $e) {
    // Executed only in PHP 5.x, will not be reached in PHP 7
}

[Shardj]

Don't worry about it, my co-worker who I gave permissions in this repo introduced throwable catches into the codebase a couple of weeks ago to solve some type error issues, so I've gone and raised the required php version to 7.0

[Jimbolino]

too bad... we still have some systems running on php 5.6
i'll send a pull request to make it compatible again ok?

[Shardj]

Yep that's absolutely fine, I've actually set you as a collaborator now so feel free to merge stuff like that as you see fit. You'll have to change the composer.json value back

[Shardj]

Great PR, thank you @tomasfejfar