Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Nächster Schultag" due date selection chip doesn't take holidays into account. #1179

Closed
Jonas-Sander opened this issue Dec 9, 2023 · 0 comments · Fixed by #1678
Closed

"Nächster Schultag" due date selection chip doesn't take holidays into account. #1179

Jonas-Sander opened this issue Dec 9, 2023 · 0 comments · Fixed by #1678
Labels
bug Something isn't working. feature: homework good first issue This issue is good for new contributors. Easy to fix. w: add-homework-page Creation Dialog of a homework. Get to it by pressing the add homework button on the homework page.

Comments

@Jonas-Sander
Copy link
Collaborator

Jonas-Sander commented Dec 9, 2023 •
edited
Loading

Describe the bug

"Nächster Schultag" due date selection chip does not take holidays into account, i.e. if tomorrow is a holiday and the "Nächster Schultag" chip is pressed then the next school day after the holiday should be chosen.

grafik

Steps to reproduce the bug

  1. Go to your phone settings and set the date to 20.12.2023
  2. Open Sharezone
  3. Go to Settings ("Einstellungen") > Account ("Mein Konto") > State ("Bundesland") and choose "Nordrhein-Westfalen"
  4. Go the homework page > Click on the button to create a homework ("+" FAB)
  5. Tap on "Nächster Schultag" chip

Current broken behavior

The due date "21.12.2023" will be selected as the "Nächster Schultag"

Expected behavior

The due date "08.01.2024" should be selected as the "Nächster Schultag" as the holidays in the state "Nordrhein-Westfalen" are from 21.12.23 to 05.01.24 (05.01 is a friday, so next school day would be monday, the 08.01.24).

See #1162
@Jonas-Sander Jonas-Sander added bug Something isn't working. feature: homework w: add-homework-page Creation Dialog of a homework. Get to it by pressing the add homework button on the homework page. labels Dec 9, 2023
@Jonas-Sander Jonas-Sander self-assigned this Dec 9, 2023
This was referenced Dec 9, 2023
Closed
Merged
@Jonas-Sander Jonas-Sander removed their assignment Jan 31, 2024
@nilsreichardt nilsreichardt added the good first issue This issue is good for new contributors. Easy to fix. label Feb 10, 2024
@ImGxrke ImGxrke mentioned this issue Jun 28, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 3, 2024
@ImGxrke @Jonas-Sander
Consider holidays for next schoolday (#1678)
9dd1f42 
Fixes #1179

---------

Co-authored-by: Jonas Sander <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working. feature: homework good first issue This issue is good for new contributors. Easy to fix. w: add-homework-page Creation Dialog of a homework. Get to it by pressing the add homework button on the homework page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Consider holidays for next schoolday
2 participants
@nilsreichardt @Jonas-Sander