Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --rollout-percentage to sz deploy android #1019

Merged
merged 7 commits into from
Sep 19, 2023

Conversation

nilsreichardt
Copy link
Member

@nilsreichardt nilsreichardt commented Sep 19, 2023

This PR adds the --rollout-percentage to sz deploy android: The percentage (between 0.0 - 1.0) of the user fraction when uploading to the rollout track (setting to 1 will complete the rollout).

Additionally, this PR adds the parameters to stable.yml (default: 0.2) and beta.yml (default: 1.0).

@github-actions
Copy link

github-actions bot commented Sep 19, 2023

Visit the preview URL for this PR (updated for commit 9ee63d4):

https://sharezone-test--pr1019-add-rollout-for-depl-dimbchv5.web.app

(expires Fri, 22 Sep 2023 16:34:46 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@Jonas-Sander
Copy link
Collaborator

Jonas-Sander commented Sep 19, 2023

To be honest I find that behavior might be a bit surprising.
If we want to do that I think at least it:

  • should be printed in the console that a 20% rollout is done
  • the url to the PlayStore Console site where one can adjust/increase the rollout should be printed in the console

(But also, if we trigger it from GitHub manually would one even notice the logs above?)

For now, I hard-coded the 20% for stable. Later on, we might add an "Is hot fix?" bool for our stable.yml and beta.yml which roll-outs to 100% immediately. As long, we don't have this, we can manually increase the rollout from 20% to 100% in the Google Play Console.

Why not use a --rollout-percentage flag? Through that one could even supply the value from GitHub Actions. I'd leave it to your choice if should still default to 20% rollout for stable in this case. I think this is the better alternative tbh.

Also just food for thought for the future: We could make a rollout a seperate concept in the CLI in the future. sz rollout android change --rollout-percentage 40. iOS doesn't seem support the same granularity, but still a phased approach which could be represented in the CLI (e.g. show rollout percentage, pause rollout).

@github-actions github-actions bot added the ci/cd label Sep 19, 2023
@nilsreichardt nilsreichardt changed the title Rollout Android stable releases by 20% Add --rollout-percentage to sz deploy android Sep 19, 2023
@nilsreichardt
Copy link
Member Author

Why not use a --rollout-percentage flag? Through that one could even supply the value from GitHub Actions. I'd leave it to your choice if should still default to 20% rollout for stable in this case. I think this is the better alternative tbh.

Yes, thanks for the suggestion. This is the best option 👍

Also just food for thought for the future: We could make a rollout a seperate concept in the CLI in the future. sz rollout android change --rollout-percentage 40. iOS doesn't seem support the same granularity, but still a phased approach which could be represented in the CLI (e.g. show rollout percentage, pause rollout).

Yes, this would be a great feature for the future because I really like the phased rollout that offers App Store Connect. However, I think it will take a long moment until I will build this because for now, I will use increase it manually via the Google Play Console.

Copy link
Collaborator

@Jonas-Sander Jonas-Sander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this way more 👍 LGTM

Would it be possible to add this?

  • should be printed in the console that a x% rollout is being done
  • the url to the PlayStore Console site where one can adjust/increase the rollout should be printed in the console

@nilsreichardt nilsreichardt added this pull request to the merge queue Sep 19, 2023
@nilsreichardt nilsreichardt removed this pull request from the merge queue due to a manual request Sep 19, 2023
@nilsreichardt nilsreichardt merged commit 2ad1056 into main Sep 19, 2023
@nilsreichardt nilsreichardt deleted the add-rollout-for-deploy-android branch September 19, 2023 18:13
github-merge-queue bot pushed a commit that referenced this pull request Sep 19, 2023
The PR #1019 also
triggered the integration tests although in `app/` only the Fastlane
file changed and this file not covered by our CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants