-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --rollout-percentage
to sz deploy android
#1019
Conversation
Visit the preview URL for this PR (updated for commit 9ee63d4): https://sharezone-test--pr1019-add-rollout-for-depl-dimbchv5.web.app (expires Fri, 22 Sep 2023 16:34:46 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b |
To be honest I find that behavior might be a bit surprising.
(But also, if we trigger it from GitHub manually would one even notice the logs above?)
Why not use a Also just food for thought for the future: We could make a |
--rollout-percentage
to sz deploy android
Yes, thanks for the suggestion. This is the best option 👍
Yes, this would be a great feature for the future because I really like the phased rollout that offers App Store Connect. However, I think it will take a long moment until I will build this because for now, I will use increase it manually via the Google Play Console. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this way more 👍 LGTM
Would it be possible to add this?
- should be printed in the console that a x% rollout is being done
- the url to the PlayStore Console site where one can adjust/increase the rollout should be printed in the console
The PR #1019 also triggered the integration tests although in `app/` only the Fastlane file changed and this file not covered by our CI.
This PR adds the
--rollout-percentage
tosz deploy android
: The percentage (between 0.0 - 1.0) of the user fraction when uploading to the rollout track (setting to 1 will complete the rollout).Additionally, this PR adds the parameters to
stable.yml
(default: 0.2) andbeta.yml
(default: 1.0).