Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace FocusManager call with focusNode.requestFocus in delayKeyboard(...). #1104

Merged
merged 1 commit into from
Oct 1, 2023

Conversation

Jonas-Sander
Copy link
Collaborator

@Jonas-Sander Jonas-Sander commented Oct 1, 2023

The old way didn't work for me to request focus for the title field in the add homework dialog. This fixes it.

Copy link
Member

@nilsreichardt nilsreichardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Btw: This will also fix the issue for the blackboard dialog 👍

@github-actions
Copy link

github-actions bot commented Oct 1, 2023

Visit the preview URL for this PR (updated for commit e0f54d6):

https://sharezone-test--pr1104-fix-focus-fbhjal9a.web.app

(expires Wed, 04 Oct 2023 20:46:56 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@Jonas-Sander Jonas-Sander added this pull request to the merge queue Oct 1, 2023
Merged via the queue into main with commit d0cc748 Oct 1, 2023
@Jonas-Sander Jonas-Sander deleted the fix-focus branch October 1, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants