Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Validator from HomeworkDialogBloc. #1120

Merged
merged 4 commits into from
Oct 9, 2023

Conversation

Jonas-Sander
Copy link
Collaborator

I didn't feel like they provided that much value so I removed them.

@Jonas-Sander Jonas-Sander marked this pull request as ready for review October 9, 2023 15:48
Copy link
Member

@nilsreichardt nilsreichardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jonas-Sander Jonas-Sander enabled auto-merge October 9, 2023 16:16
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Visit the preview URL for this PR (updated for commit 1435b74):

https://sharezone-test--pr1120-hw-dialog-remove-val-v4ad8ubh.web.app

(expires Thu, 12 Oct 2023 16:46:23 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b

@Jonas-Sander Jonas-Sander added this pull request to the merge queue Oct 9, 2023
Merged via the queue into main with commit d8b21f1 Oct 9, 2023
@Jonas-Sander Jonas-Sander deleted the hw-dialog-remove-validators branch October 9, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants