Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor getCurrentLessonIndex. #123

Merged
merged 2 commits into from
Feb 7, 2022

Conversation

Jonas-Sander
Copy link
Collaborator

  • Change comments to english.
  • Make code more readable.
  • Add a test case.
  • Rename AllLessonsOver to AllLessonsOverException.

* Change comments to english.
* Make code more readable.
* Add a test case.
* Rename `AllLessonsOver` to `AllLessonsOverException`.
Copy link
Member

@nilsreichardt nilsreichardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Visit the preview URL for this PR (updated for commit 562ae17):

https://sharezone-test--pr123-get-current-lesson-i-t3i5nh4g.web.app

(expires Mon, 14 Feb 2022 14:05:11 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@Jonas-Sander Jonas-Sander merged commit 1ce1e50 into main Feb 7, 2022
@Jonas-Sander Jonas-Sander deleted the get-current-lesson-index-refactor branch February 7, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants