Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in PackageTimeoutException and translate docs into English #130

Merged
merged 4 commits into from
Feb 28, 2022
Merged

Fix typo in PackageTimeoutException and translate docs into English #130

merged 4 commits into from
Feb 28, 2022

Conversation

nilsreichardt
Copy link
Member

  • Fixed typo in PackageTimeoutException
  • Translated doc comment of PackageTimeoutException into English
  • Translated toString method into English

@github-actions
Copy link

github-actions bot commented Feb 28, 2022 •
edited
Loading

Visit the preview URL for this PR (updated for commit 3da0df9):

https://sharezone-test--pr130-fix-typo-in-package-xjhlhr2x.web.app

(expires Mon, 07 Mar 2022 21:27:10 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Jonas-Sander
Jonas-Sander approved these changes Feb 28, 2022
View reviewed changes
Copy link
Collaborator

@Jonas-Sander Jonas-Sander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When that thing above is fixed LGTM

tools/sz_repo_cli/lib/src/common/src/package_timeout_exception.dart Outdated Show resolved Hide resolved
@nilsreichardt nilsreichardt enabled auto-merge (squash) February 28, 2022 21:22
@nilsreichardt nilsreichardt merged commit bf9328c into main Feb 28, 2022
@nilsreichardt nilsreichardt deleted the fix-typo-in-package-timeout-exeception branch February 28, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jonas-Sander Jonas-Sander Jonas-Sander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nilsreichardt @Jonas-Sander