Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unused code. #136

Merged
merged 2 commits into from
Mar 24, 2022
Merged

Delete unused code. #136

merged 2 commits into from
Mar 24, 2022

Conversation

Jonas-Sander
Copy link
Collaborator

No description provided.

@Jonas-Sander Jonas-Sander marked this pull request as draft March 20, 2022 22:28
@Jonas-Sander Jonas-Sander changed the title [WIP] Delete unused code. Delete unused code. Mar 20, 2022
@github-actions
Copy link

github-actions bot commented Mar 20, 2022

Visit the preview URL for this PR (updated for commit 8ca8c89):

https://sharezone-test--pr136-delete-unused-code-kya7mvpy.web.app

(expires Wed, 30 Mar 2022 23:08:47 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@Jonas-Sander
Copy link
Collaborator Author

@nilsreichardt Can you take a look - is there anything we should keep in your opinion?
I just deleted everything unused (except stuff in generated files) so we can discuss here the question above.
(Also look at the "Show diff" code thats automatically hidden if possible).

Personally I'm unsure if we should just delete unused code always in general (without any exception). Maybe there's some stuff which has a high probability of being used again and if we delete it would just mean that we recreate the code again in the future (as we probably forgot that we had it someday).
Do you think this applies to any code deleted in this PR or should we just delete everything?

Copy link
Member

@nilsreichardt nilsreichardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

In general, we should always delete unused code. But I think it makes sense to make exceptions, like adding features to packages which currently are not used by the app or website but made be used in the feature.

@Jonas-Sander Jonas-Sander marked this pull request as ready for review March 23, 2022 23:05
@Jonas-Sander Jonas-Sander merged commit 61203b5 into main Mar 24, 2022
@Jonas-Sander Jonas-Sander deleted the delete-unused-code branch March 24, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants