Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable soft line break for markdown. #139

Merged
merged 3 commits into from
Mar 24, 2022
Merged

Conversation

nilsreichardt
Copy link
Member

Description

Since last summer, it's possible to enable soft line breaks (flutter/packages#437). Therefore, no \ is required anymore.

I think adding the support for soft line break is the better solution instead of \ because it's completely intuitive and for nearly every user it's new that you can break a line with \.

Prevents also confusions like https://discord.com/channels/545668860859252746/616181222577668106/956087823692361768

 Before  After
Screenshot 2022-03-24 at 03 16 43 Screenshot 2022-03-24 at 03 16 17

Text:

Guten Tag,
was geht.
asdf


asdfasf


hallo\
safdfs

@github-actions
Copy link

github-actions bot commented Mar 24, 2022

Visit the preview URL for this PR (updated for commit a1fee49):

https://sharezone-test--pr139-markdown-soft-line-b-l91ioghy.web.app

(expires Thu, 31 Mar 2022 19:47:44 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@Jonas-Sander
Copy link
Collaborator

@nilsreichardt Bei den Termindetails ist das scheinbar noch nicht aktiviert

Copy link
Collaborator

@Jonas-Sander Jonas-Sander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above.
LGTM for everything else.

@nilsreichardt
Copy link
Member Author

@nilsreichardt Bei den Termindetails ist das scheinbar noch nicht aktiviert

Good catch!

@nilsreichardt nilsreichardt merged commit 1484bb4 into main Mar 24, 2022
@nilsreichardt nilsreichardt deleted the markdown-soft-line-break branch March 24, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants