Fix wrong path trigger for deploy-web-app CD
#142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit a4c19b9): https://sharezone-test--pr142-fix-wrong-file-name-yb5y1yz2.web.app (expires Fri, 15 Apr 2022 15:11:48 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Jonas-Sander
approved these changes
Apr 8, 2022
There was a problem hiding this comment.
LGTM.
I think in the best-case scenario this should have been caught by a test, but idk a way to test sth like this though. I'm not sure if there is a way (there are tools like act that run the action in a docker container which I think we could use theoretically. I wish there would be sth more akin to unit tests though, docker is more like e2e.)
|
Yes, true. But this mistake should have been caught in a review as well. A reminder to have small PRs for better review quality :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.