Upgrade to Flutter v2.10.5 #153
Conversation
|
Visit the preview URL for this PR (updated for commit f755c18): https://sharezone-test--pr153-upgrade-to-flutter-2-x9xf0jj9.web.app (expires Sat, 14 May 2022 14:03:20 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
|
Before merging we should ensure that it still builds and works for at least iOS, Android and Web. Past upgrades sometimes broke the build for some platforms I think. |
|
Also see if there is anything that applies to us: https://docs.flutter.dev/release/breaking-changes#released-in-flutter-25 |
Yeah, I'll do this. When we have integration tests (hopefully for all platforms), we will have this step in our CI integrated 💪 |
|
lol, since the Flutter update got the overview page in the mobile view a different styling xD I think we should later also add screenshot tests for the every page to avoid errors like this (should be done with integration test package). |
|
|
|
|
|
|
This reverts commit 7aea540.
… deployment target to 12.0 (#164) ## Description I'm sure that the `jitsi_meet` package is the reason why the iOS build is failing in #153. The problem is that the `jitsi_meet` package isn't maintained anymore. So it's difficult to find a fix so that #153 can be merged. There are also several issues that Android 12 is not supported anymore by the package (gunschu/jitsi_meet#376, gunschu/jitsi_meet#368, gunschu/jitsi_meet#366). There is a folk of `jitsi_meet` called `jitsi_meet_wrapper` which has better code and is maintained. So I migrated to this package (thanks to @saibotma 💙). One big disadvantage: `jitsi_meet_wrapper` uses the current Jitsi iOS SDK which requires +12.0. This means we need to drop the support for iOS 11.0 (other option would be to remove the Jitsi Feature for all users) 😞 ## Demo | iOS | Android | |-|-| | <img width="475" alt="image" src="https://user-images.githubusercontent.com/24459435/167040941-3aa87468-5779-4e10-99ea-669f4ec90e1d.png"> | <img width="522" alt="image" src="https://user-images.githubusercontent.com/24459435/167248265-8f3c21e1-5dbd-403c-975a-17508e2bc10f.png"> |
|
iOS builds are working again :) |
|
@Jonas-Sander You can review again :) |
|
Seems so that there are still some UI elements not adjusted for the dark mode. But I just saw that they don't have anything to do with the 2.10.5 upgrade because they already in https://web.sharezone.net app. I created the issues: #167, #168, #169. So I think we can merge this PR and fix the other styling issues in a different PR. |
.fvm/fvm_config.jsonToDo