Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make KeyValueStore NNBD + add tryGet methods. #157

Merged
merged 16 commits into from
May 4, 2022

Conversation

Jonas-Sander
Copy link
Collaborator

@Jonas-Sander Jonas-Sander commented May 4, 2022

The tryGet methods will probably be used by me in another PR.

@github-actions
Copy link

github-actions bot commented May 4, 2022

Visit the preview URL for this PR (updated for commit 126e5c0):

https://sharezone-test--pr157-key-value-store-non-4dkses0d.web.app

(expires Wed, 11 May 2022 14:36:08 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Copy link
Member

@nilsreichardt nilsreichardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Can you also add doc comments to the tryGet methods?

lib/key_value_store/lib/key_value_store.dart Outdated Show resolved Hide resolved
lib/key_value_store/lib/key_value_store.dart Outdated Show resolved Hide resolved
lib/key_value_store/lib/key_value_store.dart Outdated Show resolved Hide resolved
@Jonas-Sander Jonas-Sander enabled auto-merge (squash) May 4, 2022 14:25
@Jonas-Sander Jonas-Sander merged commit 9e7c077 into main May 4, 2022
@Jonas-Sander Jonas-Sander deleted the key-value-store-non-nullable branch May 4, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants